Skip to content

Conversation

@jakobbotsch
Copy link
Member

The test of time has shown that this test just ends up being another place to modify, and it has never caught anything useful. At the same time it is currently disabling several JIT optimizations to pass, but those optimizations can only be disabled with checked JIT builds, so the test ends up failing in release.

Fix #104451

The test of time has shown that this test just ends up being another
place to modify, and it has never caught anything useful. At the same
time it is currently disabling several JIT optimizations to pass, but
those optimizations can only  be disabled with checked JIT builds, so the
test ends up failing in release.

Fix dotnet#104451
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 26, 2025
@jakobbotsch jakobbotsch changed the title JIT: Skip test validating release debug info mappings JIT: Skip validation of release debug info mappings Feb 26, 2025
@jakobbotsch jakobbotsch changed the title JIT: Skip validation of release debug info mappings JIT: Skip validation of debug info mappings in optimized codegen Feb 26, 2025
@jakobbotsch jakobbotsch marked this pull request as ready for review February 26, 2025 19:53
Copilot AI review requested due to automatic review settings February 26, 2025 19:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib

@jakobbotsch jakobbotsch merged commit 998ca7b into dotnet:main Feb 26, 2025
72 checks passed
@jakobbotsch jakobbotsch deleted the fix-104451 branch February 26, 2025 20:11
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Question] JIT/Directed/debugging/debuginfo/tester fail with DOTNET_TieredCompilation=0 on Linux

2 participants