Fix .cmd scripts help arguments#1131
Merged
Merged
Conversation
jkotas
approved these changes
Dec 23, 2019
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New PR for: #1043 which was reverted in: #1110
The reason for the build break was because when setting
_argsenv variable, I was escaping the args with"which was causingPowerShellto not bind the args as an array and therefore when parsing them and passing the right Global Properties to MSBuild, we were not passing them down.I just debugged that locally and now the arguments are bound as expected, build is green and properties passed down correctly (validated via binlog).