Reenable ClientDisableTlsResume_Succeeds test#113604
Merged
rzikm merged 1 commit intodotnet:mainfrom Mar 19, 2025
Merged
Conversation
ghost
added
the
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables the ClientDisableTlsResume_Succeeds test to verify that the previously reported issue has been resolved.
- Re-enabled the TLS resume test by removing the ActiveIssue attribute
- Confirms support for running the test on Windows
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 18, 2025
Member
Author
|
/ba-g The affected test did not fail, other failures are unrelated |
wfurt
approved these changes
Mar 19, 2025
Member
wfurt
left a comment
wfurt
left a comment
There was a problem hiding this comment.
LGTM. It feels like the test was flaky for some reason but I'm fine enabling it again. If this fails again perhaps we can run it isolation e.g. no parallel or we would need to investigate deeper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran the test locally in a loop for couple of hours and could not reproduce the failure anymore. This PR reenables the test to see if the (external) issue is resolved.
Closes #103449.