Fix misaligned reads in NativeAOT code manager #113637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix replaces the native implementation of the native format decoder with the clone of the managed implementation. Fixes dotnet#113609
ghost
added
the
Member
Author
|
cc @dotnet/ilc-contrib |
jkotas
commented
Mar 18, 2025
| uintptr_t lengthBits = *pbEncoding & 0x0F; | ||
| size_t negLength = s_negLengthTab[lengthBits]; | ||
| uintptr_t shift = s_shiftTab[lengthBits]; | ||
| uint32_t result = *(PTR_uint32_t)(pbEncoding - negLength - 4); |
Member
Author
There was a problem hiding this comment.
This was tricky branch-free implementation to squeeze a few extra cycles. Exception handling is the only place where it was used.
I have replaced it with clone of much more straightforward managed implementation. We can afford to spend a few cycles on decoding EH clauses...
am11
reviewed
Mar 18, 2025
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
jkotas
commented
Mar 18, 2025
MichalStrehovsky
approved these changes
Mar 18, 2025
Member
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
There was a problem hiding this comment.
Nice cleanup too, thank you!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix replaces the native implementation of the native format decoder with the clone of the managed implementation.
Fixes #113609