Remove SLH-DSA OOM test#115341
Merged
PranavSenthilnathan merged 1 commit intodotnet:mainfrom May 6, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes a test that intentionally triggered an OOM scenario to verify that a resize loop terminates via exception, as it was not providing meaningful coverage.
- Removed ExportPkcs8PrivateKey_ResizeTerminates test to prevent intermittent CI failures
- Consolidated test coverage to rely on exception handling already validated elsewhere
Comments suppressed due to low confidence (1)
src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaContractTests.cs:605
- Removing the ExportPkcs8PrivateKey_ResizeTerminates test may reduce test coverage for verifying exception handling during resize operations. Please ensure that any critical exception handling behavior is covered by other tests.
[Theory]
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
This was referenced May 6, 2025
vcsjones
approved these changes
May 6, 2025
bartonjs
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI tests are failing with OOM sometimes so removing a test that OOMs on purpose. The test intends to make sure resizing will not overflow by making sure that eventually it will terminate. However, even if it overflows, it will throw an exception and terminate the resize loop so it's not really testing anything useful.