Skip to content

Exclude tail call counts from check to prevent unnecessary EBP frame #116413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakobbotsch merged 3 commits into from
Jun 11, 2025
Merged

Exclude tail call counts from check to prevent unnecessary EBP frame #116413

jakobbotsch merged 3 commits into from
Jun 11, 2025

Conversation

@filipnavara
Copy link
Member

@filipnavara filipnavara commented Jun 8, 2025 •
edited
Loading

This is common pattern in IL stubs. The SPMI diffs are likely to be small but there's something on linux-x64 and linux-arm.

runtime/src/coreclr/jit/regalloc.cpp

Lines 144 to 148 in 0a1fb70

if (!result && (optIndirectCallCount >= 1))
{
INDEBUG(reason = "Indirect Call");
result = true;
}

@filipnavara
Do not count tailcall calli to prevent unnecessary EBP frame
41110a2 
This is common pattern in IL stubs. The SPMI diffs are likely to be small but there's something on linux-x64.
@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 8, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 8, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Jun 8, 2025

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@filipnavara
Copy link
Member Author

filipnavara commented Jun 8, 2025

Diffs

@filipnavara filipnavara marked this pull request as ready for review June 8, 2025 16:20
am11
am11 reviewed Jun 8, 2025
View reviewed changes
@filipnavara
Copy link
Member Author

filipnavara commented Jun 10, 2025

cc @dotnet/jit-contrib

jakobbotsch
jakobbotsch reviewed Jun 10, 2025
View reviewed changes
@filipnavara filipnavara changed the title Do not count tailcall calli to prevent unnecessary EBP frame Exclude tail call counts from check to prevent unnecessary EBP frame Jun 10, 2025
@filipnavara filipnavara requested a review from jakobbotsch June 11, 2025 17:10
@filipnavara filipnavara mentioned this pull request Jun 11, 2025
Closed
jakobbotsch
jakobbotsch approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jakobbotsch
Copy link
Member

jakobbotsch commented Jun 11, 2025

/ba-g Failure is #116520

@jakobbotsch jakobbotsch merged commit 3787ee6 into dotnet:main Jun 11, 2025
108 of 110 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

+1 more reviewer

@am11 am11 am11 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@filipnavara @jakobbotsch @am11