[release/10.0-preview6] Fix HttpClientHandler.CreateNativeHandler implementation #116767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@jonathanpeppers will the change you made for the return type be in P6 or do we need to add back the return type adjustment here? |
AaronRobinsonMSFT
approved these changes
Jun 17, 2025
Member
We haven’t branched for preview 6 just yet, so it will be there. |
jkoritzinsky
added
the
Servicing-consider
jeffschwMSFT
approved these changes
Jun 17, 2025
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. we will take for consideration in 10 preview 6
This was referenced Jun 18, 2025
Open
rbhanda
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #116707 to release/10.0-preview6
/cc @jkoritzinsky
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
When the user tries to use
HttpClientin their .NET on iOS, .NET on tvOS, .NET on Mac Catalyst, or .NET on Android app, aBadImageFormatExceptionis thrown instead of the operation being successful.Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
da80937
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Local validation
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
Low, manually validated
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.