Do not send DB_IPCE_LOAD_ASSEMBLY event#117680
Merged
thaystg merged 3 commits intodotnet:mainfrom Jul 16, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the DB_IPCE_LOAD_ASSEMBLY event mechanism from the CoreCLR debugger interface. The change consolidates assembly loading notifications by moving the assembly loading callback functionality into the existing module loading event handling instead of maintaining a separate assembly loading event.
Key changes:
- Removes the separate
DB_IPCE_LOAD_ASSEMBLYevent type and associated infrastructure - Moves assembly loading callback invocation to occur during
DB_IPCE_LOAD_MODULEevent processing - Updates assembly notification logic to use module load flags instead of assembly load flags
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/vm/dbginterface.h | Removes LoadAssembly virtual method declaration from DebugInterface |
| src/coreclr/vm/assembly.cpp | Changes assembly loading to use MODULE_LOAD flag and removes assembly-specific notification logic |
| src/coreclr/vm/appdomain.hpp | Removes ATTACH_ASSEMBLY_LOAD enum constant |
| src/coreclr/debug/ee/debugger.h | Removes LoadAssembly method declaration from Debugger class |
| src/coreclr/debug/ee/debugger.cpp | Removes entire LoadAssembly method implementation |
| src/coreclr/debug/di/process.cpp | Moves assembly loading callback from DB_IPCE_LOAD_ASSEMBLY case to DB_IPCE_LOAD_MODULE case |
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
steveisok
approved these changes
Jul 15, 2025
This was referenced Jul 16, 2025
Open
Member
Author
|
/ba-g failures are unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.