Make IsAlive test reliable and re-enable it for crossgen2#117987
Merged
kg merged 2 commits intodotnet:mainfrom Jul 24, 2025
Merged
Make IsAlive test reliable and re-enable it for crossgen2#117987kg merged 2 commits intodotnet:mainfrom
kg merged 2 commits intodotnet:mainfrom
Conversation
github-actions
Bot
added
the
needs-area-label
Member
Author
|
/azp run runtime-coreclr crossgen2 outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kg
added
area-GC-coreclr
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @dotnet/gc |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a flaky test that was unreliable and re-enables it for crossgen2 testing. The test verifies WeakReference.IsAlive behavior by ensuring proper timing of object collection.
Key changes:
- Moves WeakReference creation into the array creation method to prevent dangling references
- Improves test logic to properly validate expected behavior
- Re-enables the test by removing it from the crossgen2 exclusion list
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/tests/issues.targets | Removes exclusion entry to re-enable the IsAlive test for crossgen2 |
| src/tests/GC/API/WeakReference/IsAlive.cs | Refactors test logic to create WeakReference in CreateArray method and improves validation |
Open
3 tasks
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jkotas
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #109312
For me the old version of this test fails locally even without R2R involved.