[DAC] Change EnumMethodInstancesByAddress behavior#118032
Closed
max-charlamb wants to merge 2 commits intodotnet:mainfrom
Closed
[DAC] Change EnumMethodInstancesByAddress behavior#118032max-charlamb wants to merge 2 commits intodotnet:mainfrom
EnumMethodInstancesByAddress behavior#118032max-charlamb wants to merge 2 commits intodotnet:mainfrom
Conversation
Member
Author
|
/azp run runtime-diagnostics |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the EnumMethodInstancesByAddress behavior to return only a single IXCLRDataMethodInstance representing the method instance at the given IP address, rather than enumerating through multiple instances.
Key changes:
- Simplified enumeration logic to return at most one method instance
- Moved native code check from iterator to the start enumeration function
- Replaced iterator-based approach with a single completion flag
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/coreclr/debug/daccess/task.cpp |
Simplified EnumMethodInstances::Next() to return single instance and moved native code validation to StartEnumMethodInstancesByAddress() |
src/coreclr/debug/daccess/dacimpl.h |
Replaced iterator fields with simple completion flag in EnumMethodInstances class |
src/coreclr/debug/daccess/daccess.cpp |
Added native code check in StartEnumMethodInstancesByAddress() before starting enumeration |
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies
EnumMethodInstancesByAddressto only return a single IXCLRDataMethodInstance representing the instance at the given IP address.Running diagnostics tests on new behavior