Disable Test_wait_interrupted_user_apc on NAOT due to no support for alertable waits. #118231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR disables a Windows-specific threading test (Test_wait_interrupted_user_apc) when running on Native AOT (NAOT) because the test relies on alertable waits which are not supported in NAOT.
Key Changes
- Modified the test condition to exclude Native AOT execution environments
- The test validates that wait functions handle user APCs correctly, but since NAOT doesn't support alertable waits, the test becomes inapplicable
github-actions
bot
added
the
needs-area-label
Member
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
added
area-NativeAOT-coreclr
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
This was referenced Jul 31, 2025
Open
Member
|
/ba-g the disabled test is not failing anymore. The failures are #118234 and infrastructure timeout |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test tests that our wait functions won't break in case when user APC are queued. That requires wait to be alertable, but in NAOT case, waits are not, meaning that APC won't run and test won't work. Since the whole point of the test is to make sure waits are not broken due to user APC, this test is not applicable on NAOT, therefore it needs to be disabled.