Remove unsigned implementation of ShiftRightArithmeticNarrowingSaturateEven/Odd#118338
Merged
amanasifkhalid merged 4 commits intodotnet:mainfrom Aug 6, 2025
Merged
Conversation
…teEven/Odd The uqshrnb/t instructions perform a logical shift, when the intrinsic is an arithmetic shift.
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
amanasifkhalid
approved these changes
Aug 4, 2025
Contributor
amanasifkhalid
left a comment
amanasifkhalid
left a comment
There was a problem hiding this comment.
I believe SPMI will fail with this change until we get a new collection, since it still has the old tests for the unsigned variants. Could you please bump the JIT-EE GUID as well so we can force a new collection?
Contributor
|
@snickolls-arm sorry I just introduced a merge conflict in the test files -- could you please take a look? |
Contributor
FYI @dotnet/jit-contrib |
Contributor
|
/ba-g test timeouts and crash statuses of "None" (likely other timeouts) |
This was referenced Aug 6, 2025
Open
Contributor
|
/ba-g mono build timed out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
uqshrnb/tinstructions perform a logical shift, when the intrinsic is an arithmetic shift.For reference: #94015
@dotnet/arm64-contrib