Skip to content

Add default StaticWebAssetMakeReferencedAssetOriginalItemSpecAbsolute for WebAssembly apps#118394

Merged
ilonatommy merged 2 commits intomainfrom
copilot/fix-118393
Aug 6, 2025
Merged

Add default StaticWebAssetMakeReferencedAssetOriginalItemSpecAbsolute for WebAssembly apps#118394
ilonatommy merged 2 commits intomainfrom
copilot/fix-118393

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Aug 5, 2025

This PR adds the missing StaticWebAssetMakeReferencedAssetOriginalItemSpecAbsolute property to the WebAssembly props file to ensure it has a default value when not explicitly set.

The change adds a single line to Microsoft.NET.Sdk.WebAssembly.Browser.props:

<StaticWebAssetMakeReferencedAssetOriginalItemSpecAbsolute Condition="'$(StaticWebAssetMakeReferencedAssetOriginalItemSpecAbsolute)' == ''">true</StaticWebAssetMakeReferencedAssetOriginalItemSpecAbsolute>

This mirrors the same pattern already implemented in the Blazor SDK at Microsoft.NET.Sdk.BlazorWebAssembly.Current.props and ensures that WebAssembly applications have consistent behavior with static web asset handling.

Without this property being set, WebAssembly applications may experience issues with static web asset path resolution, as described in the related ASP.NET Core issue.

Fixes #118393.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…ssembly props

Co-authored-by: ilonatommy <32700855+ilonatommy@users.noreply.github.com>
Copilot AI changed the title [WIP] Make sure StaticWebAssetMakeReferencedAssetOriginalItemSpecAbsolute for wasm apps is not empty Add default StaticWebAssetMakeReferencedAssetOriginalItemSpecAbsolute for WebAssembly apps Aug 5, 2025
Copilot AI requested a review from ilonatommy August 5, 2025 13:51
@ilonatommy ilonatommy marked this pull request as ready for review August 5, 2025 14:13
Copilot AI review requested due to automatic review settings August 5, 2025 14:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a missing default property value for WebAssembly applications to ensure consistent static web asset handling behavior. The change addresses an issue where WebAssembly apps may experience problems with static web asset path resolution due to the absence of this property.

  • Adds default value for StaticWebAssetMakeReferencedAssetOriginalItemSpecAbsolute property
  • Ensures consistency with Blazor SDK implementation
  • Fixes static web asset path resolution issues in WebAssembly applications

@ilonatommy ilonatommy requested a review from maraf August 5, 2025 14:14
@ilonatommy
Copy link
Copy Markdown
Member

ilonatommy commented Aug 6, 2025

the job that is running for 14 hours finished, the information about it was just lost somewhere on the way:
image
@akoeplinger Do you know a way to stop waiting for the result (abort running etc) or do I have to merge with main/close-open the PR to let it be mergeable?

@akoeplinger
Copy link
Copy Markdown
Member

@akoeplinger Do you know a way to stop waiting for the result (abort running etc) or do I have to merge with main/close-open the PR to let it be mergeable?

this was due to the GitHub outage and the only way is close/reopen or merge main since AzDO is already green so the job can't be retriggered.

that said, since we only require the Build Analysis check in runtime another option would've been forcing that to green with /ba-g

@jkotas jkotas deleted the copilot/fix-118393 branch August 28, 2025 21:06
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make sure StaticWebAssetMakeReferencedAssetOriginalItemSpecAbsolute for wasm apps is not empty

5 participants