Skip to content

Fix conditional usage of OrderedDictionary.TryGetValue#118441

Merged
jkotas merged 1 commit intodotnet:mainfrom
xtqqczze:net-directives2
Aug 6, 2025
Merged

Fix conditional usage of OrderedDictionary.TryGetValue#118441
jkotas merged 1 commit intodotnet:mainfrom
xtqqczze:net-directives2

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze commented Aug 6, 2025

Enable the use of OrderedDictionary<TKey, TValue>.TryGetValue(TKey, TValue, Int32) on .NET Framework and .NET Standard targets, accounting for the build condition defined in:

<ItemGroup Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp' or $([MSBuild]::VersionLessThan('$(TargetFrameworkVersion)', '9.0'))">

Although this API is only publicly available starting with .NET 10.0, it is also accessible in .NET 8.0 due to the internal inclusion of the type within System.Text.Json.

cc: @PranavSenthilnathan

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Aug 6, 2025
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

@xtqqczze xtqqczze changed the title Use OrderedDictionary<TKey,TValue>.TryGetValue Method on more targets Use OrderedDictionary<TKey,TValue>.TryGetValue(TKey, TValue, Int32) method on more targets Aug 6, 2025
@xtqqczze xtqqczze changed the title Use OrderedDictionary<TKey,TValue>.TryGetValue(TKey, TValue, Int32) method on more targets Use TryGetValue(TKey, TValue, Int32) method on more targets Aug 6, 2025
@xtqqczze xtqqczze changed the title Use TryGetValue(TKey, TValue, Int32) method on more targets Fix conditional usage of OrderedDictionary.TryGetValue Aug 6, 2025
@jkotas jkotas merged commit df500bd into dotnet:main Aug 6, 2025
89 checks passed
@xtqqczze xtqqczze deleted the net-directives2 branch August 6, 2025 17:47
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Text.Json community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants