Skip to content

Fix rebuilding mono aot cross compiler when building locally #118445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akoeplinger merged 2 commits into from
Aug 8, 2025
Merged

Fix rebuilding mono aot cross compiler when building locally #118445

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d7644a
Fix rebuilding mono aot cross compiler when building locally
akoeplinger Aug 6, 2025
e9c336a
Apply suggestion from @Copilot
akoeplinger Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/mono/mono/offsets/offsets-tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,11 +373,7 @@ def gen (self):
outfile = self.args.outfile
validate_outfile = self.args.validate_outfile
target = self.target

if validate_outfile:
f = ComparableFile ()
else:
f = open (outfile, 'w')
f = ComparableFile ()

f.write ("#ifndef USED_CROSS_COMPILER_OFFSETS\n")
if target.arch_define:
Expand Down Expand Up @@ -435,9 +431,18 @@ def gen (self):
f.write ("#endif //USED_CROSS_COMPILER_OFFSETS check\n")
f.close ()

if validate_outfile and f.compare (outfile):
print ("Offsets file has changed.", file=sys.stderr)
f.dump (outfile + ".new")
if os.path.isfile (outfile):
if f.compare (outfile):
if validate_outfile:
print ("Offsets file has changed, writing new offsets to " + outfile + ".new", file=sys.stderr)
f.dump (outfile + ".new")
else:
print ("Offsets file has changed, updating " + outfile)
f.dump (outfile)
else:
print ("Offsets file is up to date, no changes to " + outfile)
else:
f.dump (outfile)

tool = OffsetsTool ()
tool.parse_args ()
Expand Down
Loading