[clr-interp] Fix INTOP_CGT_UN_I8#118511
Merged
davidwrighton merged 1 commit intodotnet:mainfrom Aug 8, 2025
Merged
Conversation
It was treating its inputs as 4 byte integers instead of 8 byte integers
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the CLR interpreter where the INTOP_CGT_UN_I8 operation was incorrectly treating 8-byte integer inputs as 4-byte integers, causing incorrect comparison results.
Key Changes
- Corrected the data types in the unsigned 8-byte integer comparison operation from
uint32_ttouint64_t
Contributor
|
Tagging subscribers to this area: @dotnet/interop-contrib |
AaronRobinsonMSFT
approved these changes
Aug 8, 2025
jkoritzinsky
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was treating its inputs as 4 byte integers instead of 8 byte integers