SPMI: Assert map exists in repGetCookieForPInvokeCalliSig#118524
Merged
jakobbotsch merged 1 commit intodotnet:mainfrom Aug 8, 2025
Merged
SPMI: Assert map exists in repGetCookieForPInvokeCalliSig#118524jakobbotsch merged 1 commit intodotnet:mainfrom
repGetCookieForPInvokeCalliSig#118524jakobbotsch merged 1 commit intodotnet:mainfrom
Conversation
github-actions
Bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an assertion to ensure the GetCookieForInterpreterCalliSig map exists before attempting to use it in the repGetCookieForPInvokeCalliSig method. This appears to be a defensive programming fix to address issue #118522, likely preventing crashes or undefined behavior when the map is unexpectedly null or uninitialized.
Key changes:
- Added a single assertion line to validate map existence before proceeding with the method logic
Member
Author
|
cc @dotnet/jit-contrib |
EgorBo
approved these changes
Aug 8, 2025
Member
Author
|
/ba-g Infra timeouts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #118522