Skip to content

JIT: Do not mark small types RegOptional as part of GT_LONG contained by HWIntrinsic#118550

Merged
AndyAyersMS merged 1 commit intodotnet:mainfrom
saucecontrol:runtime-118466
Aug 11, 2025
Merged

JIT: Do not mark small types RegOptional as part of GT_LONG contained by HWIntrinsic#118550
AndyAyersMS merged 1 commit intodotnet:mainfrom
saucecontrol:runtime-118466

Conversation

@saucecontrol
Copy link
Copy Markdown
Member

@saucecontrol saucecontrol commented Aug 8, 2025

Fixes #118466

I was unable to get the repro from #118466 to fail when converted to an Xunit test, but this fixes the assert (and codegen) seen in the standalone repro.

Before (when bypassing the assert):

IN0015: 00004E xor      edx, edx
IN0016: 000050 vmovd    xmm0, dword ptr [V00 ebp-0x08]
IN0017: 000055 vpinsrd  xmm0, xmm0, edx, 1
IN0018: 00005B vpbroadcastq xmm0, xmm0

After:

IN0015: 00004E movzx    edx, byte  ptr [V00 ebp-0x08]
IN0016: 000052 xor      ecx, ecx
IN0017: 000054 vmovd    xmm0, edx
IN0018: 000058 vpinsrd  xmm0, xmm0, ecx, 1
IN0019: 00005E vpbroadcastq xmm0, xmm0

@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 8, 2025
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Aug 8, 2025
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@AndyAyersMS
Copy link
Copy Markdown
Member

@dotnet/jit-contrib FYI

Copy link
Copy Markdown
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this.

@AndyAyersMS AndyAyersMS merged commit 8b10891 into dotnet:main Aug 11, 2025
108 checks passed
@saucecontrol saucecontrol deleted the runtime-118466 branch August 11, 2025 21:17
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JIT: Assertion failed 'isContainable || supportsRegOptional'

2 participants