Adding GetMethodDescFromToken cDAC API#118619
Merged
rcj1 merged 2 commits intodotnet:mainfrom Aug 19, 2025
Merged
Conversation
rcj1
requested review from
Copilot and
max-charlamb
and removed request for
Copilot
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
Contributor
Author
|
SOS failing tests are EnumMethodInstanceByAddress and DrainQueue related |
src/native/managed/cdac/mscordaccore_universal/Legacy/ISOSDacInterface.cs
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the GetMethodDescFromToken method in the cDAC (Contract Data Access Component) API to retrieve method descriptors from metadata tokens. This replaces the previous implementation that simply delegated to the legacy DAC implementation.
- Adds a new
CorTokenTypeenum to define metadata token types and their bitmasks - Implements the core logic to handle different token types (FieldDef, MethodDef, TypeDef, TypeRef) using the loader contract
- Includes debug validation to compare results with the legacy implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.