Mark Marvin.ComputeHash32 as noinlining#118851
Merged
AndyAyersMS merged 1 commit intodotnet:mainfrom Aug 18, 2025
Merged
Conversation
Recent changes to the JIT's inliner may lead to this method but not all of its callees being inlined, which is not good for performance. There is not much benefit to be had by inlining this method, so mark it as noinline. Fixes (part of) dotnet#118739.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a performance issue in the Marvin hash computation by preventing the ComputeHash32 method from being inlined. Recent JIT inliner changes may cause partial inlining of this method without its callees, which degrades performance.
Key Changes
- Added
[MethodImpl(MethodImplOptions.NoInlining)]attribute toMarvin.ComputeHash32method to prevent inlining and ensure optimal performance
github-actions
Bot
added
the
needs-area-label
Member
Author
|
Similar in spirit to #118544. @EgorBo PTAL Would like to have this considered for .NET 10. |
tannergooding
approved these changes
Aug 18, 2025
Member
Author
|
@EgorBot --intel --arm --filter |
EgorBo
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent changes to the JIT's inliner may lead to this method but not all of its callees being inlined, which is not good for performance.
There is not much benefit to be had by inlining this method, so mark it as noinline.
Fixes (part of) #118739.