Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for pinned IL locals in the CoreCLR interpreter by adding a pinned flag to track local variables that have the 'pinned' modifier and ensuring they are properly marked in the GC info.
- Adds a
pinnedbit field to theInterpVarstructure to track pinned variables - Updates local variable creation to detect and store the pinned modifier from IL
- Modifies GC info generation to mark pinned variables with the
GC_SLOT_PINNEDflag
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/interpreter/compiler.h | Adds pinned field to InterpVar struct and updates CreateNextLocalVar signature |
| src/coreclr/interpreter/compiler.cpp | Implements pinned variable detection, storage, and GC info marking |
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
davidwrighton
approved these changes
Aug 22, 2025
BrzVlad
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes JIT\Directed\pinning\object-pin\object-pin