-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Clarify how to interpret the Variant value on Guid. #118987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The original description makes it hard to understand when you are not already an expert, and don't know that "don't care" bits are a term used in the linked specification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the documentation for the Guid.Variant property to make it more accessible to developers who aren't already familiar with UUID specification terminology. The change clarifies how to interpret the variant value and provides a concrete example.
- Explains that only the first 2 bits might be relevant depending on the UUID variant
- Clarifies what "don't-care" bits means in this context
- Adds a practical example showing how to interpret the value for UUIDv7
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
|
API introduced by #104124. cc @tannergooding |
tannergooding
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll want to make a similar change against dotnet-api-docs to ensure that the official docs are updated.
The original description makes it hard to understand when you are not already an expert, and don't know that "don't care" bits are a term used in the linked specification.