Make wasm corerun build regular#119029
Merged
AaronRobinsonMSFT merged 2 commits intodotnet:mainfrom Aug 24, 2025
Merged
Conversation
AaronRobinsonMSFT
requested review from
Copilot,
jkoritzinsky,
lewing,
radekdoulik and
steveisok
AaronRobinsonMSFT
added
arch-wasm
Contributor
|
Tagging subscribers to this area: @hoyosjs |
This was referenced Aug 23, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes the build process for corewasmrun (the WebAssembly version of corerun) by integrating it into the regular build workflow and ensuring all artifacts are placed in the correct bin location like other corerun scenarios.
Key changes include:
- Integrating WASM host building into the standard CoreCLR build process
- Adding proper install handling for WASM executable assets (JS, WASM, and data files)
- Updating subset dependencies to include
clr.corelibfor browser builds
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/inc/pinvokeoverride.h | Changes include directive from quotes to angle brackets for coreclrhost.h |
| src/coreclr/inc/bundle.h | Changes include directive from quotes to angle brackets for coreclrhost.h |
| src/coreclr/hosts/corewasmrun/CMakeLists.txt | Reorganizes target linking and updates install destination to dedicated corewasmrun directory |
| src/coreclr/CMakeLists.txt | Simplifies host subdirectory inclusion logic to build hosts on all non-mobile platforms |
| eng/native/functions.cmake | Adds WASM-specific install handling for executable assets (.js, .wasm, .data files) |
| eng/Subsets.props | Adds clr.corelib dependency to browser builds in subset replacement logic |
jkoritzinsky
approved these changes
Aug 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the current wasm build for
corewasmrun, which is wasm's version ofcorerun, and places all artifacts in the correct bin location like othercorerunscenarios. The work flow forcorewasmrunis now much simpler../build.sh -os browser -c Debug --subset clr.runtime+libs./dotnet.sh build -c Release src/mono/sample/wasm/simple-serverartifacts/bin/coreclr/browser.wasm.Debug/corewasmrun)./src/mono/sample/wasm/simple-server/bin/Release/net8.0/HttpServer, in thecorewasmrundirectory.