Added change to application culture in config#119269
Merged
dariatiurina merged 4 commits intoSep 2, 2025
Merged
Conversation
github-actions
Bot
added
the
needs-area-label
jkotas
added
os-browser
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #37258 by ensuring consistency in culture settings throughout the application. The change updates the configuration to store the detected culture value when ICU resources are being processed.
Key Changes
- Adds assignment of the detected culture value to
config.applicationCulturein the ICU resource loading process
javiercn
reviewed
Sep 2, 2025
javiercn
approved these changes
Sep 2, 2025
Member
javiercn
left a comment
javiercn
left a comment
There was a problem hiding this comment.
Looks good to me, but @ilonatommy knows best :).
ilonatommy
approved these changes
Sep 2, 2025
…tiurina/runtime into 37258-culture-change-error
maraf
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/aspnetcore#37258 by adding detected by runtime culture to the application config, which helps maintain consistency in culture settings throughout the application.
Changes:
config.applicationCultureto the detected culture value in thegetIcuResourceNamefunction.