Implement CEE_CKFINITE in the interpreter#119548
Merged
kg merged 1 commit intodotnet:mainfrom Sep 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the CEE_CKFINITE instruction in the .NET interpreter, which validates that floating-point values are finite (not NaN or infinity) and throws an ArithmeticException if they are not. This fixes three JIT regression test failures.
Key changes:
- Adds new CKFINITE interpreter opcodes for R4 (float) and R8 (double) types
- Implements helper functions to validate finite values using std::isfinite
- Integrates the CKFINITE instruction compilation and execution logic
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/vm/interpexec.cpp | Adds CkfiniteHelper functions and CKFINITE opcode execution cases |
| src/coreclr/interpreter/inc/intops.def | Defines new INTOP_CKFINITE_R4 and INTOP_CKFINITE_R8 opcodes |
| src/coreclr/interpreter/compiler.cpp | Implements CEE_CKFINITE instruction compilation logic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes JIT\Regression\JitBlue\DevDiv_370233 and JIT\Regression\JitBlue\DevDiv_377155. Unmasks a different failure in JIT\Regression\JitBlue\DevDiv_362706.