Simple ComWrappers APIs by rcj1 · Pull Request #120114 · dotnet/runtime

rcj1 · 2025-09-25T20:00:32Z

Adding GetComWrappersCCWData, IsComWrappersCCW, and IsComWrappersRCW cDAC APIs

Copilot

Pull Request Overview

This pull request implements cDAC (Contract-based Data Access Component) APIs for simple ComWrappers functionality. The main purpose is to add three new cDAC APIs: GetComWrappersCCWData, IsComWrappersCCW, and IsComWrappersRCW, while also fixing a DAC bug on ARM architecture and renaming GetPrimitiveType to GetBinderType for broader use.

Key changes include:

Implementation of three new ComWrappers cDAC APIs with full functionality
ARM DAC bug fix by removing incorrect thumb code clearing
Renaming and broadening the scope of type lookup functionality

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
SOSDacImpl.cs	Implements the three new ComWrappers cDAC APIs and updates method name usage
ManagedObjectWrapperLayout.cs	New data contract for managed object wrapper reference count
ManagedObjectWrapperHolderObject.cs	New data contract for managed object wrapper holder
SignatureTypeProvider.cs	Updates method call to use new GetBinderType name
RuntimeTypeSystem_1.cs	Renames GetPrimitiveType to GetBinderType for broader usage
ComWrappers_1.cs	Implements core ComWrappers contract functionality
Constants.cs	Adds global constants for ComWrappers functionality
DataType.cs	Adds new data types for managed object wrapper contracts
IRuntimeTypeSystem.cs	Updates interface to use GetBinderType instead of GetPrimitiveType
IComWrappers.cs	Adds new method signatures to ComWrappers interface
interoplibinterface_comwrappers.h	Adds cdac_data template specialization for ManagedObjectWrapperHolderObject
datadescriptor.inc	Adds new data type definitions and global variables
datadescriptor.h	Includes ComWrappers header for feature support
appdomain.cpp	Caches NativeObjectWrapper method table for cDAC usage
interoplibabi.h	Adds cdac_data template specialization for ManagedObjectWrapperLayout
comwrappers.hpp	Adds forward declarations for QueryInterface methods
request.cpp	Fixes ARM DAC bug by removing thumb code clearing
SignatureDecoder.md	Updates documentation to reflect GetBinderType rename
ComWrappers.md	Updates documentation with new API definitions and implementation details

src/coreclr/vm/appdomain.cpp

…mwrappers

src/coreclr/debug/daccess/request.cpp

src/coreclr/interop/inc/interoplibabi.h

...e/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/ComWrappers_1.cs

src/coreclr/interop/comwrappers.hpp

src/coreclr/vm/datadescriptor/datadescriptor.h

src/coreclr/interop/comwrappers.hpp

src/coreclr/vm/datadescriptor/datadescriptor.inc

...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs

Copilot

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated 7 comments.

src/coreclr/debug/daccess/request.cpp

src/coreclr/vm/vars.cpp

src/coreclr/interop/comwrappers.cpp

docs/design/datacontracts/ComWrappers.md

...e/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/ComWrappers_1.cs

src/coreclr/vm/datadescriptor/datadescriptor.inc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.

...e/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/ComWrappers_1.cs

...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs

jkoritzinsky

Looking good! Just one more thing and then its good!

...anaged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/ComWrappersVtablePtrs.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated 1 comment.

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs

…er.Legacy/SOSDacImpl.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated 4 comments.

...d/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/ManagedObjectWrapperLayout.cs

.../Microsoft.Diagnostics.DataContractReader.Contracts/Data/ManagedObjectWrapperHolderObject.cs

...anaged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/ComWrappersVtablePtrs.cs

...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs

rcj1 added 3 commits September 21, 2025 16:16

e

2888d44

merge

d52af16

adding simple comwrappers cDAC APIs

8a54a7a

rcj1 requested review from Copilot, davidwrighton, hoyosjs, jkoritzinsky, jkotas, max-charlamb and noahfalk September 25, 2025 20:00

Copilot AI reviewed Sep 25, 2025

View reviewed changes

github-actions bot added the area-Diagnostics-coreclr label Sep 25, 2025

dotnet-policy-service bot assigned rcj1 Sep 25, 2025

rcj1 mentioned this pull request Sep 24, 2025

[cDAC] Support APIs used by SOS #117782

Open

32 tasks

jkotas reviewed Sep 25, 2025

View reviewed changes

src/coreclr/vm/appdomain.cpp Outdated Show resolved Hide resolved

rcj1 added 5 commits September 25, 2025 15:00

uint

1a145d9

fixing function pointer cast

82361c3

Merge branch 'main' into comwrappers

e42c7fa

e

8439a7d

Merge branch 'comwrappers' of https://github.com/rcj1/runtime into co…

f68b75c

…mwrappers

max-charlamb reviewed Sep 26, 2025

View reviewed changes

code review

759f27f

jkoritzinsky reviewed Sep 27, 2025

View reviewed changes

src/coreclr/interop/comwrappers.hpp Show resolved Hide resolved

src/coreclr/vm/datadescriptor/datadescriptor.h Outdated Show resolved Hide resolved

src/coreclr/interop/comwrappers.hpp Outdated Show resolved Hide resolved

src/coreclr/vm/datadescriptor/datadescriptor.inc Show resolved Hide resolved

e

45d66bc

AaronRobinsonMSFT added this to the 11.0.0 milestone Oct 2, 2025

rcj1 added 2 commits October 2, 2025 11:37

e

4e1385c

[skip ci]

161df49

rcj1 force-pushed the comwrappers branch from 161df49 to 4e1385c Compare October 17, 2025 21:16

max-charlamb reviewed Oct 20, 2025

View reviewed changes

...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs Show resolved Hide resolved

build-analysis bot mentioned this pull request Oct 20, 2025

Test failure: baseservices/exceptions/stackoverflow/stackoverflowtester/stackoverflowtester.cmd #110173

Open

build-analysis bot mentioned this pull request Feb 18, 2026

[android][clr] No peer certificates when executing System.Net.Http.Functional.Tests on Android emulator #124526

Open

code review

511e86b

Copilot AI review requested due to automatic review settings February 18, 2026 23:08

Copilot started reviewing on behalf of rcj1 February 18, 2026 23:09 View session

code review

c285203

Copilot AI reviewed Feb 18, 2026

View reviewed changes

Apply suggestions from code review

5f2a846

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 19, 2026 00:04

Copilot started reviewing on behalf of rcj1 February 19, 2026 00:04 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

...e/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/ComWrappers_1.cs Show resolved Hide resolved

...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs Show resolved Hide resolved

jkoritzinsky reviewed Feb 19, 2026

View reviewed changes

...anaged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/ComWrappersVtablePtrs.cs Outdated Show resolved Hide resolved

code review

74088bd

jkoritzinsky approved these changes Feb 19, 2026

View reviewed changes

Apply suggestions from code review

d37b470

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 19, 2026 00:42

Copilot started reviewing on behalf of rcj1 February 19, 2026 00:43 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

rcj1 added 2 commits February 18, 2026 17:30

fix

3a7d481

Change loop variable type from int to size_t

6ccfea3

Copilot AI review requested due to automatic review settings February 19, 2026 02:36

Copilot started reviewing on behalf of rcj1 February 19, 2026 02:37 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs Outdated Show resolved Hide resolved

rcj1 and others added 2 commits February 18, 2026 19:19

Change loop variable type from size_t to unsigned int

024cf5a

Update src/native/managed/cdac/Microsoft.Diagnostics.DataContractRead…

a2c0e6e

…er.Legacy/SOSDacImpl.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 19, 2026 03:21

Copilot started reviewing on behalf of rcj1 February 19, 2026 03:22 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

rcj1 merged commit 1774582 into dotnet:main Feb 19, 2026
109 of 113 checks passed

rcj1 deleted the comwrappers branch February 19, 2026 07:05

dotnet-maestro bot mentioned this pull request Feb 20, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#5009

Open

Conversation

rcj1 commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

jkoritzinsky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

rcj1 commented Sep 25, 2025 •

edited

Loading