Fix race condition in Microsoft.Extensions.Configuration test#120242
Merged
jkotas merged 1 commit intodotnet:mainfrom Sep 30, 2025
Merged
Fix race condition in Microsoft.Extensions.Configuration test#120242jkotas merged 1 commit intodotnet:mainfrom
jkotas merged 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a race condition in Microsoft.Extensions.Configuration tests where variable initialization and null checks were creating potential null reference exceptions during concurrent operations. The fix removes unnecessary null checks and initialization tracking variables, simplifying the code to use a do-while loop pattern that guarantees at least one execution.
Key changes:
- Removed redundant null initialization and tracking variables
- Replaced while loops with do-while loops to ensure variables are always assigned before assertions
- Removed temporary instrumentation code that was added for debugging the race condition
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ConfigurationTests.cs | Simplified loop logic by removing optionsInitialized tracking and null initialization, using do-while pattern |
| EnvironmentVariablesTest.cs | Removed debugging instrumentation code and applied same race condition fix with do-while pattern |
jkotas
commented
Sep 30, 2025
src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ConfigurationTests.cs
Show resolved
Hide resolved
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration |
jkotas
commented
Sep 30, 2025
...es/Microsoft.Extensions.Configuration.EnvironmentVariables/tests/EnvironmentVariablesTest.cs
Show resolved
Hide resolved
tarekgh
approved these changes
Sep 30, 2025
This was referenced Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #109904