[release/10.0] Avoid custom attribute routine in NetEventSource#120431
Closed
github-actions[bot] wants to merge 9 commits intorelease/10.0from
Closed
[release/10.0] Avoid custom attribute routine in NetEventSource#120431github-actions[bot] wants to merge 9 commits intorelease/10.0from
github-actions[bot] wants to merge 9 commits intorelease/10.0from
Conversation
noahfalk
approved these changes
Oct 6, 2025
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
JulieLeeMSFT
added
the
NO-MERGE
…ns.Concurrent.ConcurrentCollectionsEventSource to use string based constructors
Member
|
@EgorBot scenario-awslambda -arm -intel |
Member
|
@JulieLeeMSFT @EgorBo any plans for this PR? If we are not decided to take it, would it make sense to switch it to Draft, or Close it for now? |
Member
|
converted to draft. |
Member
|
Since this PR is targeting release/10.0, this is a reminder that code complete is Monday November 17. If you want the changes in the PR in the release, please merge it on time. |
Member
|
Not servicing for 10. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #120422 to release/10.0
/cc @ManickaP @EgorBo
Customer Impact
.NET 10.0 regressed startup time for trivial workloads as was reported by the AWS team in #120288. We suspect it's some new generic instantiations we introduced in .NET 10.0 around number parsing, since that is not easy to fix/backport, we just applied a few general improvements to regain the losses. This PR removes redundant GetCustomAttribute calls by setting EventSource name in tha base ctor instead of relying on the reflection to obtain it from the attribute. We plan to simplify/automate this with a Source Generator (in fact, it's already done like that in the corelib), but for now it's changed by hands. This PR improves this sub-graph.
Regression
Testing
Validated that events are collected normally
Risk
Low