[cDAC] Publish managed transport package#120851
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the cDAC (Contract-based Debug Access Component) transport package build configuration to publish packages for both the target runtime and the SDK runtime identifier. The changes modify how the mscordaccore_universal library files are included in the package, supporting both native runtime-specific builds and managed any-runtime builds.
Key Changes:
- Modified package build logic to create two package variants: one for the target runtime and one for the SDK runtime
- Updated file inclusion patterns to differentiate between native runtime-specific files and managed any-runtime files
- Simplified the
DotNetCdacBinDirpath definition to support the new multi-variant packaging approach
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/installer/pkg/projects/cdac-packages.proj |
Adds logic to build the transport package twice: once for $(TargetRid) and once for $(NETCoreSdkRuntimeIdentifier) |
src/installer/pkg/projects/Microsoft.DotNet.Cdac.Transport/Microsoft.DotNet.Cdac.Transport.pkgproj |
Adds conditional file inclusion logic to package native files for target runtime and managed files for SDK runtime |
Directory.Build.props |
Simplifies DotNetCdacBinDir path by removing the /$(PortableTargetRid)/publish suffix |
...staller/pkg/projects/Microsoft.DotNet.Cdac.Transport/Microsoft.DotNet.Cdac.Transport.pkgproj
Outdated
Show resolved
Hide resolved
|
What's the intended set of files for the managed package (as compared to the rid-based ones which is the published DAC)? (Just trying to figure out if there's a better/different recommended way to do this as pkgproj is funky). |
|
Ilonly assets. |
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
|
/ba-g test failures unrelated to PR |
No description provided.