Mark memory-intensive Utf8JsonWriterTests for OuterLoop and 64-bit only#120925
Merged
Mark memory-intensive Utf8JsonWriterTests for OuterLoop and 64-bit only#120925
Conversation
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix OutOfMemoryException in Utf8JsonWriterTests
Mark memory-intensive Utf8JsonWriterTests for OuterLoop and 64-bit only
Oct 20, 2025
stephentoub
reviewed
Oct 21, 2025
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Utf8JsonWriterTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Oct 21, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses OutOfMemoryException failures in two Utf8JsonWriter tests by restricting them to run only in 64-bit outer loop scenarios. Both tests allocate extremely large strings (170 million characters) which can exhaust memory in resource-constrained environments or 32-bit processes.
Key changes:
- Added
[ConditionalFact(typeof(Environment), nameof(Environment.Is64BitProcess))]to ensure tests only run on 64-bit processes - Added
[OuterLoop]attribute to move tests out of default CI runs
…ocess Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
eiriktsarpalis
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original prompt
Fixes #120918
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.