[wasm][coreclr] Extract call helpers to separate source file#120944
Merged
radekdoulik merged 5 commits intodotnet:mainfrom Oct 21, 2025
Merged
[wasm][coreclr] Extract call helpers to separate source file#120944radekdoulik merged 5 commits intodotnet:mainfrom
radekdoulik merged 5 commits intodotnet:mainfrom
Conversation
And use output of work in progress generator to get more thunks.
Contributor
|
Tagging subscribers to this area: @mangod9 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors WASM call helper functions by extracting them from the main helpers.cpp file into a new dedicated callhelpers.cpp source file. The changes include adding support for additional thunk signatures generated by a work-in-progress InterpToNativeGenerator tool.
Key changes:
- Extracted call helper functions and signature-to-thunk mappings to a separate source file
- Added new thunk functions for additional parameter/return type combinations, particularly for float32, float64, and various int32/int64 parameter patterns
- Updated the build system to include the new callhelpers.cpp file
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/coreclr/vm/wasm/helpers.cpp | Removed call helper functions and thunk mapping table; added include for new callhelpers.hpp header |
| src/coreclr/vm/wasm/callhelpers.hpp | New header file declaring the StringToWasmSigThunk structure and external references to global thunk arrays |
| src/coreclr/vm/wasm/callhelpers.cpp | New source file containing all call helper function implementations and the thunk mapping table |
| src/coreclr/vm/CMakeLists.txt | Added callhelpers.cpp to the build configuration for WASM architecture |
jkotas
reviewed
Oct 21, 2025
jkotas
reviewed
Oct 21, 2025
jkotas
reviewed
Oct 21, 2025
jkotas
approved these changes
Oct 21, 2025
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
AaronRobinsonMSFT
approved these changes
Oct 21, 2025
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
This was referenced Oct 21, 2025
21 tasks
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And use output of work in progress generator to get more thunks.