Conversation
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the legacy cDAC APIs to support a future private cDAC implementation by:
- Extracting legacy code into a separate package (
Microsoft.Diagnostics.DataContractReader.Legacy) with public visibility - Adding extensibility for custom contract implementations via
additionalFactoriesparameter - Exposing
GetContract<TContract>()publicly to enable access to contracts outside the default registry
Reviewed Changes
Copilot reviewed 23 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| mscordaccore_universal.csproj | Updates project reference to point to the new Legacy package and removes obsolete Interop.BOOL.cs reference |
| Entrypoints.cs | Makes entrypoint methods public and passes null for additionalFactories parameter in initialization calls |
| ContractDescriptorTarget.cs | Adds additionalFactories parameter to creation methods and passes it to CachingContractRegistry |
| CachingContractRegistry.cs | Adds logic to register additional contract factories during initialization |
| TypeNameBuilder.cs | Changes visibility to public and fixes ArgumentException constructor call |
| SOSDacImpl.cs | Changes class visibility from internal to public |
| SOSDacImpl.IXCLRDataProcess.cs | Changes class visibility to public and seals EnumMethodInstances class |
| SOSDacImpl.ICLRDataEnumMemoryRegions.cs | Changes class visibility from internal to public |
| OutputBufferHelpers.cs | Changes class visibility from internal to public |
| Microsoft.Diagnostics.DataContractReader.Legacy.csproj | New project file for the Legacy package |
| Interop.BOOL.cs | New file containing BOOL enum previously shared via CommonPath |
| IXCLRData.cs | Changes all interface and struct visibility from internal to public |
| ISOSDacInterface.cs | Changes all interface, struct, and enum visibility from internal to public |
| ICLRData.cs | Changes interface visibility from internal to public |
| ConversionExtensions.cs | Changes class and ToAddress method visibility to public |
| ClrDataTask.cs | Changes class visibility from internal to public |
| ClrDataStackWalk.cs | Changes class visibility from internal to public |
| ClrDataModule.cs | Changes class visibility from internal to public |
| ClrDataMethodInstance.cs | Changes class visibility from internal to public |
| ClrDataFrame.cs | Changes class visibility from internal to public |
| ClrDataAddress.cs | Changes struct and marshaller visibility from internal to public |
| IContractFactory.cs | Adds ContractType property to interface |
| ContractRegistry.cs | Adds abstract GetContract() method |
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/TypeNameBuilder.cs
Outdated
Show resolved
Hide resolved
...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/IContractFactory.cs
Show resolved
Hide resolved
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/TypeNameBuilder.cs
Outdated
Show resolved
Hide resolved
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader/CachingContractRegistry.cs
Show resolved
Hide resolved
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader/ContractDescriptorTarget.cs
Outdated
Show resolved
Hide resolved
…er.Legacy/TypeNameBuilder.cs Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
…into cdac-private-updates
jkoritzinsky
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does some work and refactoring in order to facilitate a private version of the cDAC.