Fix CS8762 suppression in ConcurrentBag#121122
Merged
stephentoub merged 1 commit intodotnet:mainfrom Oct 27, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes an unnecessary compiler warning suppression (CS8762) in the ConcurrentBag<T> class by restructuring the conditional logic. The refactoring changes from a separate boolean assignment followed by an if-check to a combined if-statement with the same condition, allowing the compiler to properly track nullability constraints without needing a pragma suppression.
Key Changes:
- Refactored the
TryStealmethod to eliminate the intermediategotItemboolean variable - Combined the conditional expression directly into the if-statement to satisfy nullability analysis
eiriktsarpalis
approved these changes
Oct 27, 2025
Member
Author
|
/ba-g build timeout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36132