Skip to content

Use JIT assumptions when passing to RhpNewArray* helpers #121139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 2 commits into from
Oct 29, 2025
Merged

Use JIT assumptions when passing to RhpNewArray* helpers #121139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf27ba4
Use JIT assumptions when passing to RhpNewArray* helpers
kant2002 Oct 28, 2025
5afe1e6
Update signature of RhNewArray
kant2002 Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/InternalCalls.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ internal static class InternalCalls

[RuntimeImport(RuntimeLibrary, "RhpNewArrayFast")]
[MethodImpl(MethodImplOptions.InternalCall)]
internal static extern unsafe object RhpNewArrayFast(MethodTable* pEEType, int length);
internal static extern unsafe object RhpNewArrayFast(MethodTable* pEEType, nint length);

#if FEATURE_64BIT_ALIGNMENT
[RuntimeImport(RuntimeLibrary, "RhpNewFastAlign8")]
Expand All @@ -114,7 +114,7 @@ internal static class InternalCalls

[RuntimeImport(RuntimeLibrary, "RhpNewArrayFastAlign8")]
[MethodImpl(MethodImplOptions.InternalCall)]
internal static extern unsafe object RhpNewArrayFastAlign8(MethodTable* pEEType, int length);
internal static extern unsafe object RhpNewArrayFastAlign8(MethodTable* pEEType, nint length);

[RuntimeImport(RuntimeLibrary, "RhpNewFastMisalign")]
[MethodImpl(MethodImplOptions.InternalCall)]
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/RuntimeExports.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public static unsafe object RhNewObject(MethodTable* pEEType)
}

[RuntimeExport("RhNewArray")]
public static unsafe object RhNewArray(MethodTable* pEEType, int length)
public static unsafe object RhNewArray(MethodTable* pEEType, nint length)
{
Debug.Assert(pEEType->IsSzArray);

Expand Down
4 changes: 2 additions & 2 deletions src/coreclr/nativeaot/Runtime/portable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ FCIMPL1(Object *, RhpNewFinalizable, MethodTable* pEEType)
}
FCIMPLEND

FCIMPL2(Array *, RhpNewArrayFast, MethodTable * pArrayEEType, int numElements)
FCIMPL2(Array *, RhpNewArrayFast, MethodTable * pArrayEEType, intptr_t numElements)
{
Thread * pCurThread = ThreadStore::GetCurrentThread();
gc_alloc_context * acontext = pCurThread->GetAllocContext();
Expand Down Expand Up @@ -221,7 +221,7 @@ FCIMPL1(Object*, RhpNewFastMisalign, MethodTable* pEEType)
}
FCIMPLEND

FCIMPL2(Array*, RhpNewArrayFastAlign8, MethodTable* pArrayEEType, int numElements)
FCIMPL2(Array*, RhpNewArrayFastAlign8, MethodTable* pArrayEEType, intptr_t numElements)
{
Thread* pCurThread = ThreadStore::GetCurrentThread();
gc_alloc_context* acontext = pCurThread->GetAllocContext();
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtime/RuntimeImports.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ internal static IntPtr RhHandleAllocCrossReference(object value, IntPtr context)

[MethodImpl(MethodImplOptions.InternalCall)]
[RuntimeImport(RuntimeLibrary, "RhNewArray")]
internal static extern unsafe Array RhNewArray(MethodTable* pEEType, int length);
internal static extern unsafe Array RhNewArray(MethodTable* pEEType, nint length);

[MethodImpl(MethodImplOptions.InternalCall)]
[RuntimeImport(RuntimeLibrary, "RhNewVariableSizeObject")]
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/nativeaot/Test.CoreLib/src/System/Runtime/RuntimeImports.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ internal static IntPtr RhGetModuleSection(TypeManagerHandle module, ReadyToRunSe

[MethodImpl(MethodImplOptions.InternalCall)]
[RuntimeImport(RuntimeLibrary, "RhNewArray")]
private static extern unsafe Array RhNewArray(MethodTable* pEEType, int length);
private static extern unsafe Array RhNewArray(MethodTable* pEEType, nint length);

[MethodImpl(MethodImplOptions.InternalCall)]
[RuntimeImport(RuntimeLibrary, "RhNewString")]
Expand Down
Loading