Mark debugger tests as ConditionalFact to skip on NativeAOT#121152
Merged
MichalStrehovsky merged 2 commits intomainfrom Oct 29, 2025
Merged
Mark debugger tests as ConditionalFact to skip on NativeAOT#121152MichalStrehovsky merged 2 commits intomainfrom
MichalStrehovsky merged 2 commits intomainfrom
Conversation
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Convert tests to use ConditionalFact for platform compatibility
Mark debugger tests as ConditionalFact to skip on NativeAOT
Oct 29, 2025
jkotas
approved these changes
Oct 29, 2025
Member
|
/ba-g infrastructure timeout |
Open
3 tasks
MichalStrehovsky
deleted the
copilot/convert-tests-to-conditional-fact
branch
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates debugger-related tests in ActivityTests.cs to use conditional execution based on platform support for debugger type proxy attributes. These tests were previously marked with [Fact] and are now marked with [ConditionalFact] to ensure they only run on platforms where debugger attributes are supported (i.e., not on NativeAOT).
Key Changes
- Converted five test methods from
[Fact]to[ConditionalFact]with platform detection - All changes target tests that validate debugger display and debugger proxy functionality
- Pattern is consistent with similar debugger tests across other libraries in the codebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five debugger-related tests added in #121054 fail in NativeAOT outerloop runs where DebuggerDisplay/DebuggerTypeProxy attributes are unsupported.
Changes
Converted five test methods in
ActivityTests.csfrom[Fact]to[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))]:TestActivityDebuggerDisplayTestActivityDebuggerProxyTestActivityContextDebuggerDisplayTestActivityLinkDebuggerDisplayTestActivityEventDebuggerDisplayThis matches the pattern used for similar debugger tests throughout the codebase (System.Linq, System.Collections.Concurrent, System.Collections.Immutable, etc.) and ensures tests are skipped on platforms where
PlatformDetection.IsDebuggerTypeProxyAttributeSupportedreturns false.Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.