[wasm][coreclr] Implement IsInCalleesFrames#121185
Merged
radekdoulik merged 2 commits intodotnet:mainfrom Oct 30, 2025
Merged
Conversation
This fixes Thread::MakeStackwalkerCallback and AssemblyNative_GetExecutingAssembly Fixes dotnet#120905
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the IsInCalleesFrames function for WebAssembly (WASM) platform. Previously, the function was unimplemented and would assert with an error message, always returning FALSE. The new implementation compares the given stack pointer with the display's stack pointer to determine if the given stack pointer is in callee frames.
Key Changes
- Replaced assertion-based stub with actual implementation for WASM platform
- Added stack pointer comparison logic consistent with other platforms (ARM, ARM64, AMD64, etc.)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jkotas
approved these changes
Oct 29, 2025
AaronRobinsonMSFT
approved these changes
Oct 29, 2025
Member
Author
|
/ba-g unrelated build timeouts |
This was referenced Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
Thread::MakeStackwalkerCallbackand thus alsoAssemblyNative_GetExecutingAssembly.Fixes #120905