Clarify documentation workflows for assemblies with UseCompilerGeneratedDocXmlFile#121271
Clarify documentation workflows for assemblies with UseCompilerGeneratedDocXmlFile#121271
Conversation
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
84c2fd0 to
3091206
Compare
|
@ericstj Could you please review this - is this accurate description of the current process? |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the documentation workflow guidelines to provide clearer guidance on how API documentation is handled for different types of libraries. The key change is differentiating between libraries that use compiler-generated documentation (newer libraries) and those that rely on manually curated documentation in the dotnet-api-docs repository (older libraries).
Key changes:
- Restructured the documentation workflow section to explain two distinct paths based on the
UseCompilerGeneratedDocXmlFileproperty - Added explicit guidance on when triple-slash comments sync to dotnet-api-docs and when they serve as source of truth
- Updated cross-references between project guidelines and API guidelines documents
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/coding-guidelines/project-guidelines.md | Replaced explanation of UseCompilerGeneratedDocXmlFile=false with a reference to the expanded documentation workflow section |
| docs/coding-guidelines/adding-api-guidelines.md | Expanded documentation section to distinguish between two workflows: compiler-generated docs (default) and manually curated docs, with clear guidance for each |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
stephentoub
left a comment
There was a problem hiding this comment.
Looks right to me, thanks
|
/ba-g markdown only |
|
@ericstj I have tried to incorporate your suggestions. PTLA |
|
/ba-g doc only change |
Adds clarification from dotnet/dotnet-api-docs#12000 (comment) about the two documentation workflows based on the
UseCompilerGeneratedDocXmlFileproperty.Key points:
<UseCompilerGeneratedDocXmlFile>false</UseCompilerGeneratedDocXmlFile>(older assemblies, System.Private.CoreLib): dotnet-api-docs is source of truth; triple-slash comments sync once for new APIs onlyChanges:
Both documents now consistently explain when and where to update documentation based on the assembly's configuration.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/dotnet/dotnet-api-docs/issues/comments/3476392274curl -s REDACTED(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.