[Bounds checks] Tighten pRange in MergeEdgeAssertions via X != CNS assertions#121273
Merged
EgorBo merged 2 commits intodotnet:mainfrom Nov 3, 2025
Merged
[Bounds checks] Tighten pRange in MergeEdgeAssertions via X != CNS assertions#121273EgorBo merged 2 commits intodotnet:mainfrom
EgorBo merged 2 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the JIT's range check optimization by adding logic to handle not-equal (!=) assertions. The change allows the optimizer to tighten ranges when it encounters assertions of the form var != cnstLimit by checking if the current range boundaries match the limit value and adjusting them accordingly.
- Replaces simple skip behavior for
!=assertions with range tightening logic - When
var != 100and range is[100, X], tightens to[101, X] - When
var != 100and range is[Y, 100], tightens to[Y, 99]
Open
3 tasks
Member
Author
|
PTAL @dotnet/jit-contrib a small change to improve bounds checks |
jakobbotsch
approved these changes
Nov 3, 2025
Member
Author
|
/ba-g deadletter. (And |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #121259
When we already have, say,
[1..10]range forXand we encounterX != 1assertion, we can tighten the range to[2..10]Removes bounds checks for the following snippet:
Diffs