Runtime-async continuation object reading with Cordb#121432
Merged
rcj1 merged 2 commits intodotnet:mainfrom Dec 1, 2025
Merged
Runtime-async continuation object reading with Cordb#121432rcj1 merged 2 commits intodotnet:mainfrom
rcj1 merged 2 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds special handling for continuation types in the debugger to map them to their base continuation class type for debugging purposes. The variable name "IfSubTypeCreated" suggests this is a lazily-initialized global that may be NULL before any continuation subtypes are created.
- Adds checks for continuation types using
IsContinuation()in debugger type conversion functions - Replaces continuation subtypes with the base continuation class type (
g_pContinuationClassIfSubTypeCreated) for debugger type information - Applies this pattern consistently across both EE debugger and DAC debugger interface implementations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/coreclr/debug/ee/debugger.cpp | Adds continuation type handling in TypeHandleToBasicTypeInfo and TypeHandleToExpandedTypeInfo to replace continuation types with base class |
| src/coreclr/debug/daccess/dacdbiimpl.cpp | Adds continuation type handling in GetClassTypeInfo and TypeHandleToBasicTypeInfo (DAC version) with same replacement pattern |
This was referenced Nov 7, 2025
Open
noahfalk
reviewed
Nov 7, 2025
max-charlamb
reviewed
Nov 7, 2025
Contributor
Author
|
/ba-g unrelated fails |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that we are able to access continuation objects through APIs such as CordbObjectValue::GetFieldValue. As the dynamically generated continuation types with the local variable fields do not have metadata, we use the parent class which does have metadata. We will therefore not be able to view the locals fields through these APIs, but with the low likelihood that someone is digging this deep into implementation details, this should be an acceptable trade-off.