Report CORINFO_CALLCONV_GENERIC to JIT

[MichalStrehovsky]

Outerloops are broken.

Apparently we got away without reporting this until the test in #121130 was added. Not reporting the calling convention results in this not kicking in:

runtime/src/coreclr/jit/importer.cpp

Lines 7291 to 7297 in 5e97723

	eeGetMethodSig(resolvedToken.hMethod, &sig);
	if (sig.numArgs != info.compMethodInfo->args.numArgs ||
	sig.retType != info.compMethodInfo->args.retType ||
	sig.callConv != info.compMethodInfo->args.callConv)
	{
	BADCODE("Incompatible target for CEE_JMPs");
	}

and failing the test.

Cc @dotnet/ilc-contrib

[Copilot]

Pull Request Overview

This PR fixes broken outerloop tests by ensuring that the CORINFO_CALLCONV_GENERIC calling convention flag is properly reported to the JIT compiler. Previously, the AOT compiler was not setting the generic flag in method signatures, which caused the JIT to miss important optimizations/checks when compiling generic method calls.

• Added Generic flag to MethodSignatureFlags enum
• Implemented IsGeneric property on MethodSignature to check the flag
• Set the flag during ECMA signature parsing when the metadata indicates a generic signature
• Report the flag to JIT through CORINFO_CALLCONV_GENERIC in the calling convention

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/coreclr/tools/Common/TypeSystem/Ecma/EcmaSignatureParser.cs	Set the Generic flag when parsing method signatures with generic parameters from ECMA metadata
src/coreclr/tools/Common/TypeSystem/Common/MethodDesc.cs	Add Generic flag enum value and IsGeneric property to MethodSignature class
src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs	Report CORINFO_CALLCONV_GENERIC to JIT when signature is generic

[MichalStrehovsky]

There was an error trying to commit changes.

Thanks for nothing, Github.

[MichalStrehovsky]

/azp run runtime-nativeaot-outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jkotas]

Thanks

[dotnet-policy-service]

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

[jkotas]

/ba-g timeouts