Update MSVC build flags to meet SDL requirements#121823
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-meta |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables specific MSVC compiler warnings as errors to meet Microsoft's Security Development Lifecycle (SDL) requirements, addressing a regression introduced by PR #121510.
Key Changes
- Enhanced documentation for the
/sdlcompiler flag to clarify its security features - Added 11 SDL-required compiler warnings as errors (4018, 4055, 4242, 4244, 4267, 4302, 4509, 4510, 4611, 4701, 4510, 4610)
- Included comprehensive documentation explaining which warnings are covered by
/sdland which need explicit configuration
Member
|
/backport to release/10.0 |
Contributor
|
Started backporting to |
Contributor
|
@agocke backporting to git am output$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Update MSVC flags to meet SDL requirements
Using index info to reconstruct a base tree...
M eng/native/configurecompiler.cmake
Falling back to patching base and 3-way merge...
Auto-merging eng/native/configurecompiler.cmake
CONFLICT (content): Merge conflict in eng/native/configurecompiler.cmake
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Update MSVC flags to meet SDL requirements
Error: The process '/usr/bin/git' failed with exit code 128 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables specific MSVC compiler warnings as error so that we continue to meet SDL requirements. Addresses regression introduced by #121510.