[clr-ios] Enable CoreCLR tests for tvOS in extra-platforms#122606
[clr-ios] Enable CoreCLR tests for tvOS in extra-platforms#122606kotlarmilos merged 9 commits intodotnet:mainfrom
Conversation
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR enables CoreCLR tests for tvOS in the extra-platforms pipelines, contributing to issue #120055. The changes include runtime support modifications for tvOS's unique platform constraints and pipeline configuration updates.
Key changes:
- Added tvOS-specific pthread synchronization support to handle platform limitations where Mach exceptions and System V IPC are unavailable
- Enabled FEATURE_STUBPRECODE_DYNAMIC_HELPERS for tvOS in CMake configuration
- Updated pipeline configurations to run CoreCLR tests on both tvOS simulator and device platforms
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/pal/src/thread/process.cpp | Removed trailing whitespace |
| src/coreclr/pal/src/include/pal/threadsusp.hpp | Added tvOS support to use pthread condition variables for thread synchronization since System V semaphores are unavailable |
| src/coreclr/clrfeatures.cmake | Extended FEATURE_STUBPRECODE_DYNAMIC_HELPERS to include tvOS alongside iOS and MacCatalyst |
| eng/pipelines/extra-platforms/runtime-extra-platforms-ioslikesimulator.yml | Enabled tvossimulator_arm64 platform for CoreCLR runtime and library tests |
| eng/pipelines/extra-platforms/runtime-extra-platforms-ioslike.yml | Enabled tvos_arm64 platform for CoreCLR tests while temporarily disabling ios_arm64 due to separate Helix queue upgrade issue |
vitek-karas
left a comment
There was a problem hiding this comment.
The code changes look good...
Description
This PR enables CoreCLR tests for tvOS in the extra-platforms pipelines.
Contributes to #120055