Skip to content

Conversation

@radekdoulik
Copy link
Member

No description provided.

@radekdoulik radekdoulik added this to the Future milestone Jan 6, 2026
Copilot AI review requested due to automatic review settings January 6, 2026 17:10
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@radekdoulik
Copy link
Member Author

Fix build error in https://dev.azure.com/dnceng-public/public/_build/results?buildId=1244620&view=logs&jobId=1236c61a-731e-5ae8-c2ca-7ddc55e20b2e&j=1236c61a-731e-5ae8-c2ca-7ddc55e20b2e&t=836834d0-290a-514a-aa10-6022eb7d1f99

##[error]src/libraries/System.Private.CoreLib/src/System/Threading/ThreadPool.Browser.Threads.cs(13,36): error CS1696: (NETCORE_ENGINEERING_TELEMETRY=Build) Single-line comment or end-of-line expected
/__w/1/s/src/libraries/System.Private.CoreLib/src/System/Threading/ThreadPool.Browser.Threads.cs(13,36): error CS1696: Single-line comment or end-of-line expected [/__w/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]
##[error]src/libraries/System.Private.CoreLib/src/System/Threading/ThreadPool.Browser.Threads.cs(14,6): error CS1513: (NETCORE_ENGINEERING_TELEMETRY=Build) } expected
/__w/1/s/src/libraries/System.Private.CoreLib/src/System/Threading/ThreadPool.Browser.Threads.cs(14,6): error CS1513: } expected [/__w/1/s/src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj]

Build FAILED.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a syntax error in the browser threading implementation file that would have prevented the browser build from compiling. The file had malformed structure with missing line breaks and a missing closing brace for the namespace.

Key Changes

  • Adds proper line break after #pragma warning restore IDE0060
  • Adds missing closing brace } for the namespace declaration

@pavelsavara
Copy link
Member

/ba-g ci timeouts

@radekdoulik radekdoulik merged commit c0c6ad5 into dotnet:main Jan 6, 2026
147 of 152 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants