[browser][coreCLR] enable System.Runtime.Tests on CI as Release build#122980
Merged
pavelsavara merged 17 commits intodotnet:mainfrom Jan 12, 2026
Merged
[browser][coreCLR] enable System.Runtime.Tests on CI as Release build#122980pavelsavara merged 17 commits intodotnet:mainfrom
pavelsavara merged 17 commits intodotnet:mainfrom
Conversation
This was referenced Jan 7, 2026
d3ff07f to
390b5ab
Compare
This was referenced Jan 8, 2026
Open
390b5ab to
46b6bd6
Compare
radekdoulik
reviewed
Jan 9, 2026
radekdoulik
reviewed
Jan 9, 2026
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/DateTimeTests.cs
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enables System.Runtime.Tests on CI for browser/CoreCLR as a Release build, addressing multiple components to support this functionality.
Key changes include:
- Adding missing function signatures in CoreCLR's interpreter-to-managed call helpers for browser/WASM
- Implementing workarounds for test loading issues and access checks on WASM
- Refactoring JavaScript/TypeScript code to reduce exported symbols and improve modularity by moving FS operations to a centralized location
- Switching CI pipeline configuration from Debug to Release build
- Disabling IL trimming temporarily for CoreCLR on WASM
- Marking failing tests with ActiveIssue attributes to track them systematically
Reviewed changes
Copilot reviewed 43 out of 44 changed files in this pull request and generated 23 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tasks/WasmAppBuilder/coreclr/ManagedToNativeGenerator.cs | Adds missing function signature cookies for interpreter-to-managed calls |
| src/native/rollup.config.defines.js | Removes CI build check from isDebug condition to ensure proper debug configuration |
| src/native/libs/Common/JavaScript/types/emscripten.ts | Removes FS_createPath, FS_createDataFile, and addFunction from EmscriptenModule interface |
| src/native/libs/Common/JavaScript/ems-ambient/index.ts | Adds FS object with createPath and createDataFile methods, removes maybeExit |
| src/native/corehost/browserhost/loader/dotnet.d.ts | Removes FS_createPath, FS_createDataFile, and addFunction from EmscriptenModule interface |
| src/native/corehost/browserhost/libBrowserHost.footer.js | Adds AJSDCE_Deps workaround for acorn-optimizer and reformats dependency list |
| src/native/corehost/browserhost/host/host.ts | Updates FS API calls to use ems.FS instead of ems.Module |
| src/native/corehost/browserhost/CMakeLists.txt | Changes BrowserHost-Static from PUBLIC to PRIVATE linking and adds comment markers |
| src/mono/wasm/testassets/WasmBrowserRunMainOnly/WasmBrowserRunMainOnly.csproj | Adds CoreCLR-specific properties for invariant globalization and disables trimming |
| src/mono/browser/test-main.js | Adds timing output to log test execution duration |
| src/mono/browser/build/WasmApp.InTree.props | Adds comment referencing IL trimming issue |
| src/libraries/tests.proj | Restricts browser smoke tests to Mono runtime only |
| src/libraries/pretest.proj | Removes Mono-only restriction from WASM provisioning |
| eng/testing/tests.browser.targets | Adds CoreCLR-specific test support properties and disables trimming |
| eng/pipelines/runtime.yml | Changes build config to Release and adds CoreCLR library tests template |
| eng/pipelines/common/templates/wasm-coreclr-library-tests.yml | New file defining CoreCLR library test pipeline configuration |
| eng/pipelines/common/templates/browser-wasm-coreclr-build-tests.yml | Updates build config from Debug to Release |
| eng/native.wasm.targets | Reduces EmccExportedRuntimeMethod and EmccExportedFunction items |
| src/libraries/Common/tests/WasmTestRunner/WasmTestRunner.cs | Implements workaround for test assembly loading issue |
| src/coreclr/vm/wasm/callhelpers-interp-to-managed.cpp | Adds numerous missing function signatures for WASM interop |
| src/coreclr/interpreter/compiler.cpp | Adds TARGET_WASM conditional to skip EmitCallsiteCallout workaround |
| src/libraries/System.Runtime/tests/System.Runtime.Tests/System/*.cs | Adds ActiveIssue attributes to disable failing tests for Browser+CoreCLR |
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/WeakReferenceTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Runtime/JitInfoTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/GCTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/DateTimeTests.cs
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Attributes.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/DoubleTests.cs
Outdated
Show resolved
Hide resolved
...em.Runtime/tests/System.Runtime.Tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/StringTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Int128Tests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/HalfTests.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
maraf
reviewed
Jan 12, 2026
src/mono/wasm/testassets/WasmBrowserRunMainOnly/WasmBrowserRunMainOnly.csproj
Outdated
Show resolved
Hide resolved
Member
Author
maraf
approved these changes
Jan 12, 2026
This was referenced Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoreCLR
callhelpers-interp-to-managed.cppSystem.Delegate.DelegateConstructresults in exception #121955WasmTestRunner
Emscripten build
AJSDCEBrowserHost-Staticprivate linking tooEmccExportedRuntimeMethodand other exportsCI & MSBuild
runtimepipeline toReleasewasm-coreclr-library-tests.ymlWasmTestLogExitCode,WasmTestAppendElementOnExit,WasmTestExitOnUnhandledErrorfor library tests on CoreCLRSystem.Runtime.Tests
Fixes #120707
Fixes #123030