Fix method signature for memmove and memset in SpanHelpers.ByteMemOps#123006
Merged
kotlarmilos merged 1 commit intodotnet:mainfrom Jan 8, 2026
Merged
Fix method signature for memmove and memset in SpanHelpers.ByteMemOps#123006kotlarmilos merged 1 commit intodotnet:mainfrom
kotlarmilos merged 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-memory |
EgorBo
approved these changes
Jan 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes modifier ordering issues in two method declarations that were causing build errors when building the Mono runtime. The changes ensure compliance with the C# modifier ordering rules specified in .editorconfig.
- Reorders modifiers from
private static unsafe externtoprivate static extern unsafefor two internal methods - Resolves IDE0036 compiler errors that were blocking Mono builds
This was referenced Jan 8, 2026
Open
This was referenced Jan 9, 2026
Member
|
I am wondering why this was not caught by CI. Do you happen to know? It is not the first time something like this happened, but I was not able to figure out how it sneaked through. |
Member
Author
|
I was building runtime packs using the following command: I see that the ios packs were built on the PR. I will check if there is any difference when DotNetBuildAllRuntimePacks is passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes modifiers order encountered when building mono runtime.
Introduced in #122791