Bring throw helpers to PUSH_COOP_PINVOKE_FRAME plan

[am11]

Fixes #116375.

[dotnet-policy-service]

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

[am11]

@janvorli, FYI, I have brought back ldmxcsr to see if all tests pass with it included. It was failing Exceptions/ForeignThread/ForeignThreadExceptions/ForeignThreadExceptions.cmd tests without it https://helix.dot.net/api/2019-06-17/jobs/91c6751b-23aa-4f7e-b012-635d2ea381fe/workitems/Exceptions/console.

[janvorli]

It was failing Exceptions/ForeignThread/ForeignThreadExceptions/ForeignThreadExceptions.cmd tests without it https://helix.dot.net/api/2019-06-17/jobs/91c6751b-23aa-4f7e-b012-635d2ea381fe/workitems/Exceptions/console.

That is due to a different problem - wrong unwind info of the IL_Throw. If you do what @jkotas said, the issue goes away.

[am11]

Thanks.

If you do what @jkotas said, the issue goes away.

Already pushed in 7cb82b1. I will try undoing the other change locally and push once this PR runs complete.

[am11]

@janvorli, win-x64 pri0 tests are now passing. But if I drop ldmxcsr change from 7cb82b1, ForeignThreadExceptions failed. Could you please show me how you addressed @jkotas' feedback; and was it different than how I did?

[am11]

PTAL. One less PAL_VirtualUnwind call (and six more to go before we can let go of libunwind dependency 😁).

[janvorli]

Could you please show me how you addressed @jkotas' feedback; and was it different than how I did?

I did it the same way as you, there is no difference in that part. But I've also removed the ldmxcsr from the Context.asm which you still seem to have.

[janvorli]

LGTM, just few nits. Thank you!

[janvorli]

/azp run runtime-coreclr outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[am11]

osx-arm64 failure is an existing one; failed in a previous run as well https://dev.azure.com/dnceng-public/public/_build/results?buildId=1255235&view=logs&j=86a95901-e0d9-5eec-3cb6-04a12f80e719&t=27788b50-9372-56cb-e5f4-7bfe19754c51.

#123195

[janvorli]

/ba-g the PAL test failure is #123195

[am11]

This benchmark:

using System;
using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;

BenchmarkSwitcher
    .FromAssembly(typeof(IlThrowBenchmark).Assembly)
    .Run(args);

[MemoryDiagnoser]
[SimpleJob(warmupCount: 5, iterationCount: 20)]
public class IlThrowBenchmark
{
    private static volatile int _sink;

    [Benchmark]
    public void ThrowAndCatch()
    {
        try
        {
            Thrower();
        }
        catch (InvalidOperationException ex)
        {
            _sink = ex.HResult;
        }
    }

    private static void Thrower()
    {
        throw new InvalidOperationException("boom");
    }
}

resulted in:

Method	Toolchain	Mean	Error	StdDev	Ratio	Allocated
ThrowAndCatch	898e3513f0~1 (previous to merge commit on main)	2,667.4 ns	43.74 ns	76.61 ns	1.00	320 B
ThrowAndCatch	898e3513f0 (merge commit)	977.8 ns	18.79 ns	17.58 ns	0.37	320 B