Skip to content

[WIP] Remove instances of DisablePackageBaselineValidation set to true #123229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
+2 −13
Closed

[WIP] Remove instances of DisablePackageBaselineValidation set to true #123229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1e4b46
Initial plan
Copilot Jan 15, 2026
cf4dc96
Remove DisablePackageBaselineValidation from project files
Copilot Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/coding-guidelines/project-guidelines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ By default, packable project (mostly source projects) have APICompat package val
This also includes _package baseline validation_ which automatically restores a previously produced package version (from the NuGet feeds) of the project and compares the public API to guard against breaking changes.

When adding a brand new library, package baseline validation needs to be disabled temporarily as there's no previously produced package available yet. This should be done
by setting the `DisablePackageBaselineValidation` property to true: https://github.com/dotnet/runtime/blob/634641c806b129bd6892e071aece3f4916ea519d/src/libraries/System.Linq.AsyncEnumerable/src/System.Linq.AsyncEnumerable.csproj#L14-L17
by setting the `DisablePackageBaselineValidation` property to true.

## TargetFramework conditions
`TargetFramework` conditions should be avoided in the first PropertyGroup as that causes DesignTimeBuild issues: https://github.com/dotnet/project-system/issues/6143
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/System.IO.Ports/pkg/runtime.native.System.IO.Ports.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
<UseRuntimePackageDisclaimer>true</UseRuntimePackageDisclaimer>
<!-- This is a native package and doesn't contain any ref/lib assets. -->
<NoWarn>$(NoWarn);NU5128</NoWarn>
<!-- Disabling baseline validation since this is binary blob -nd we do not need API compat. -->
<DisablePackageBaselineValidation>true</DisablePackageBaselineValidation>
<PackageReadmeFilePath>$(MSBuildThisFileDirectory)../src/PACKAGE.md</PackageReadmeFilePath>
</PropertyGroup>

Expand Down
5 changes: 0 additions & 5 deletions src/libraries/System.Linq.AsyncEnumerable/src/System.Linq.AsyncEnumerable.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,6 @@
<!-- Due to heavy use of callbacks, ConfigureAwait(false) should not be used.
The callbacks should be allowed to run in the original context. -->
<NoWarn>$(NoWarn);CA2007</NoWarn>

<!-- Disabling baseline validation since this is a brand new package.
Once this package has shipped a stable version, the following line
should be removed in order to re-enable validation. -->
<DisablePackageBaselineValidation>true</DisablePackageBaselineValidation>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/mono/wasm/templates/Microsoft.NET.Runtime.WebAssembly.Templates.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

<PropertyGroup>
<TargetFramework>$(NetCoreAppToolCurrent)</TargetFramework>
<IsShipping>false</IsShipping>

<PackageType>Template</PackageType>
<!-- when changing the net version also change it in template.json in the templates -->
Expand All @@ -17,7 +18,6 @@
<NoWarn>$(NoWarn);NU5128</NoWarn>
<IsPackable>true</IsPackable>
<EnableDefaultCompileItems>false</EnableDefaultCompileItems>
<DisablePackageBaselineValidation>true</DisablePackageBaselineValidation>
<!-- TODO: Add package readme -->
<EnableDefaultPackageReadmeFile>false</EnableDefaultPackageReadmeFile>
</PropertyGroup>
Expand Down
4 changes: 0 additions & 4 deletions src/tools/illink/src/linker/Mono.Linker.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@
<IsPackable>true</IsPackable>
<IsShipping>false</IsShipping>
<PackageId>Microsoft.NET.ILLink</PackageId>
<!-- Disabling baseline validation since this is a brand new package.
Once this package has shipped a stable version, the following line
should be removed in order to re-enable validation. -->
<DisablePackageBaselineValidation>true</DisablePackageBaselineValidation>
<!-- There are currently no translations, so the satellite assemblies are a waste of space. -->
<EnableXlfLocalization>false</EnableXlfLocalization>
<NoWarn Condition="'$(DotNetBuildSourceOnly)' == 'true'">$(NoWarn);CS8524</NoWarn>
Expand Down
Loading