Skip to content

Avoid incorrectly resolving a MonoClass for MONO_TYPE_GENERICINST when loading custom attribute values. #123439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Venkad000 wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Avoid incorrectly resolving a MonoClass for MONO_TYPE_GENERICINST when loading custom attribute values. #123439

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ba11567
Adding check for MONO_TYPE_GENERICINST in load_cattr_value
Venkad000 Jan 21, 2026
74895d8
Merge branch 'main' into roslynfix
Venkad000 Jan 21, 2026
a694649
Merge branch 'main' into roslynfix
Venkad000 Jan 24, 2026
c6f8356
Merge branch 'main' into roslynfix
lewing Jan 31, 2026
7b0bbe9
Merge branch 'main' into roslynfix
Venkad000 Feb 8, 2026
ae88465
Merge branch 'main' into roslynfix
Venkad000 Feb 19, 2026
45c74ff
Merge branch 'main' into roslynfix
Venkad000 Feb 23, 2026
8b81663
Merge branch 'main' into roslynfix
Venkad000 Mar 2, 2026
5e5d956
Merge branch 'main' into roslynfix
lewing Mar 3, 2026
efc140d
Merge branch 'main' into roslynfix
Venkad000 Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/mono/mono/metadata/custom-attrs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,9 @@ load_cattr_value (MonoImage *image, MonoType *t, MonoObject **out_obj, const cha
{
int type = t->type;
guint32 slen;
MonoClass *tklass = m_type_data_get_klass (t);
MonoClass *tklass = NULL;
if (type != MONO_TYPE_GENERICINST)
tklass = m_type_data_get_klass (t);

if (out_obj)
*out_obj = NULL;
Expand Down Expand Up @@ -858,7 +860,7 @@ load_cattr_value_boxed (MonoDomain *domain, MonoImage *image, MonoType *t, const
gpointer val = load_cattr_value (image, t, &obj, p, boundp, end, error);
if (!is_ok (error))
return NULL;
g_assert (!val);
g_assert ((!val) || (val && t->type == MONO_TYPE_GENERICINST));
return obj;
} else {
void *val = load_cattr_value (image, t, NULL, p, boundp, end, error);
Expand Down
Loading