Added Adler32 to System.IO.Hashing.#123601
Merged
stephentoub merged 19 commits intodotnet:mainfrom Feb 13, 2026
Merged
Conversation
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
This comment was marked as outdated.
This comment was marked as outdated.
akoeplinger
added
area-System.IO.Hashing
and removed
needs-area-label
bartonjs
reviewed
Jan 25, 2026
src/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.cs
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
stephentoub
reviewed
Jan 26, 2026
huoyaoyuan
reviewed
Jan 26, 2026
vcsjones
reviewed
Jan 26, 2026
src/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.cs
Outdated
Show resolved
Hide resolved
This was referenced Jan 26, 2026
Open
vcsjones
reviewed
Jan 26, 2026
src/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.cs
Outdated
Show resolved
Hide resolved
vcsjones
reviewed
Jan 27, 2026
src/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.cs
Outdated
Show resolved
Hide resolved
vcsjones
reviewed
Jan 27, 2026
src/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.cs
Outdated
Show resolved
Hide resolved
AraHaan
commented
Jan 28, 2026
src/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.Vectorized.cs
Outdated
Show resolved
Hide resolved
3 tasks
vcsjones
reviewed
Jan 29, 2026
src/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.Avx2Sse.cs
Outdated
Show resolved
Hide resolved
This was referenced Jan 30, 2026
Member
Author
|
Let me know if these changes look good as is or if any more changes are needed. |
stephentoub
reviewed
Feb 10, 2026
src/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 10, 2026
src/libraries/System.IO.Hashing/src/System/IO/Hashing/Adler32.cs
Outdated
Show resolved
Hide resolved
Fixes dotnet#90191. Signed-off-by: AraHaan <seandhunt_7@yahoo.com>
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
Also another attempt at fixing the expected hash values as well.
Signed-off-by: AraHaan <seandhunt_7@yahoo.com>
Signed-off-by: AraHaan <seandhunt_7@yahoo.com>
Signed-off-by: AraHaan <seandhunt_7@yahoo.com>
Signed-off-by: AraHaan <seandhunt_7@yahoo.com>
Co-authored-by: Kevin Jones <vcsjones@github.com>
Added another remarks entry.
…c to UpdateScalar(). Also added optional spot where ARM intrinsics can be used in UpdateScalar if vectorization is not possible.
Signed-off-by: AraHaan <seandhunt_7@yahoo.com>
Signed-off-by: AraHaan <seandhunt_7@yahoo.com>
stephentoub
force-pushed
the
add-adler32-to-system-io-hashing
branch
from
f776e19 to
55235a4
Compare
stephentoub
approved these changes
Feb 12, 2026
bartonjs
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #90191.