Skip to content

Fix crossgen2 nobubble memory leak #123627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 5 commits into from
Feb 3, 2026
Merged

Fix crossgen2 nobubble memory leak #123627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1a776d1
Fix crossgen2 nobubble memleak
t-mustafin Jan 26, 2026
d2453f1
Feedback
t-mustafin Feb 2, 2026
be1dcb5
Feedback
t-mustafin Feb 2, 2026
562a325
Do not force clean _corInfoImpls cause it is not ConditionalWeakTable
t-mustafin Feb 2, 2026
b641eb8
Merge branch 'main' into crossgen2_pipeline_nobubble_memleak
jkotas Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/ManifestMetadataTableNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public interface ISignatureEmitter
void MaterializeSignature();
}

public class ManifestMetadataTableNode : HeaderTableNode
public class ManifestMetadataTableNode : HeaderTableNode, IDisposable
{
/// <summary>
/// Map from simple assembly names to their module indices. The map gets prepopulated
Expand Down Expand Up @@ -329,5 +329,10 @@ internal byte[] GetManifestAssemblyMvidTableData()
}
return manifestAssemblyMvidTable;
}

public void Dispose()
{
_modulesWhichMustBeIndexable = null;
}
}
}
6 changes: 5 additions & 1 deletion src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/ReadyToRunCodegenCompilation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,7 +977,11 @@ public ISymbolNode GetFieldRvaData(FieldDesc field)

public override void Dispose()
{
Array.Clear(_corInfoImpls);
// Workaround for https://github.com/dotnet/runtime/issues/23103.
// ManifestMetadataTable.Dispose() allows to break circular reference
// ConcurrentBag<EcmaModule> -> EcmaModule -> EcmaAssembly -> ReadyToRunCompilerContext -> ... -> ConcurrentBag<EcmaModule>.
// This circular reference along with #23103 prevents objects from being collected by GC.
_nodeFactory.ManifestMetadataTable.Dispose();
}

public string GetReproInstructions(MethodDesc method)
Expand Down
Loading